Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update container labels #239

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

avnishsinghh
Copy link
Contributor

No description provided.

@jmtcsngr
Copy link
Member

Waiting to decide if we want to keep publishing the images.

Copy link
Collaborator

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use this but I have some questions for us to answer:

  1. Is $RELEASE_VERSION a "github release", or the newest tag? We've not been very good about doing formal github releases.
  2. There are other images to build also. The original build here was so that Adam could auto-publish the OpenAPI docs on release. The frontend app resides in this repo under /frontend and is a node/vite project. There is also a reverse proxy under /docker/proxy. Is it practical to build all three here? Should we?

In principle, I think we should aim to building the images on github, and then modify the deployment procedure to be more like "build VM, pull the images from github and configure".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants