Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't destroy Password when PowerAuthAuthentication is GCed #608

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Don't destroy Password when PowerAuthAuthentication is GCed #608

merged 1 commit into from
Jul 25, 2024

Conversation

hvge
Copy link
Member

@hvge hvge commented Jul 25, 2024 •
edited
Loading

This PR fixes potential random authentication failures caused by unwanted Password object destroy, when PowerAuthAuthentication is released by GC.

Fix #606
Fix #607

@hvge hvge requested a review from kober32 July 25, 2024 13:22
kober32
kober32 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hvge hvge merged commit fff34bf into develop Jul 25, 2024
1 check passed
@hvge hvge deleted the issues/607-android-password-destroy branch July 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password is destroyed when PowerAuthAuthentication is released by GC Random fail in android tests
2 participants
@hvge @kober32