Fix #1722: Cannot remove callbacks due to foreign key constraint #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnpsk
force-pushed
the
issues/1722-remove-callbacks
branch
from
4af9652
to
f3990e8
Compare
banterCZ
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1722 by adding
enabledcolumn to thepa_application_callbacktable for soft-delete purpose. When delete callback request is processed, a database record is not physically deleted anymore, insteadenabledis set to false.As @banterCZ suggested I tried
@SQLRestriction("enabled = true")on the entity level, which applies filter to queries, basically appending "where enabled = true" to each query. So a disabled callback can't be listed, updated nor deleted repeatedly. The delete method on the repository is overridden to do an update instead. I added some tests for that.