Fix #1748: High db update load because of callback event circuit breaker #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanstrobl
requested changes
Oct 18, 2024
banterCZ
reviewed
Oct 18, 2024
| @@ -110,32 +110,6 @@ | |||
| <createSequence sequenceName="pa_app_callback_event_seq" startValue="1" incrementBy="50" cacheSize="20"/> | |||
| </changeSet> | |||
|
|
|||
| <changeSet id="8" logicalFilePath="powerauth-java-server/1.9.x/20240704-callback-event-table.xml" author="Jan Pesek"> | |||
There was a problem hiding this comment.
@zcgandcomp @korbelm How will we manage our environments? Will we remove these columns manually?
There was a problem hiding this comment.
if there is any manual activity needed, please create ticket, i will fix test environments
There was a problem hiding this comment.
This is about dropping two unused columns, but there will be another issue regarding the FK constraint dropping. I will create more detailed issue for you later.
romanstrobl
previously approved these changes
Oct 18, 2024
zcgandcomp
reviewed
Oct 21, 2024
...java/io/getlime/security/powerauth/app/server/service/callbacks/CallbackUrlEventService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
failure_countandtimestamp_last_failurecolumns frompa_application_callbacktable.resetTimeoutapp configuration property tofailureResetTimeout.failureCountandtimestampLastFailurevariables used by circuit breaker in local cache, the same cache as for caching rest clients.