code refactoring

wwmm · Feb 24, 2025 · 8141721 · 8141721
1 parent 5bd074d
commit 8141721
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/src/contents/ui/DelegatePluginsList.qml b/src/contents/ui/DelegatePluginsList.qml
@@ -8,6 +8,7 @@ import org.kde.kirigami as Kirigami
 Item {
     id: delegateItem
 
+    required property var listModel
     required property int index
     required property bool bypass
     required property string name
@@ -70,10 +71,10 @@ Item {
                         icon.name: "delete"
                         displayHint: Kirigami.DisplayHint.IconOnly
                         onTriggered: {
-                            pluginsListModel.remove(index, 1);
-                            const indexStart = pluginsListModel.index(0, 0);
-                            const indexEnd = pluginsListModel.index(pluginsListModel.count - 1, 0);
-                            pluginsListModel.dataChanged(indexStart, indexEnd, []);
+                            listModel.remove(index, 1);
+                            const indexStart = listModel.index(0, 0);
+                            const indexEnd = listModel.index(listModel.count - 1, 0);
+                            listModel.dataChanged(indexStart, indexEnd, []);
                         }
                     }
                 ]
@@ -83,10 +84,10 @@ Item {
                 listItem: listItemDelegate
                 listView: pluginsListView
                 onMoveRequested: (oldIndex, newIndex) => {
-                    const indexStart = pluginsListModel.index(0, 0);
-                    const indexEnd = pluginsListModel.index(pluginsListModel.count - 1, 0);
-                    pluginsListModel.move(oldIndex, newIndex, 1);
-                    pluginsListModel.dataChanged(indexStart, indexEnd, []);
+                    const indexStart = listModel.index(0, 0);
+                    const indexEnd = listModel.index(listModel.count - 1, 0);
+                    listModel.move(oldIndex, newIndex, 1);
+                    listModel.dataChanged(indexStart, indexEnd, []);
                 }
             }
 

diff --git a/src/contents/ui/PageStreamsEffects.qml b/src/contents/ui/PageStreamsEffects.qml
@@ -33,6 +33,10 @@ Kirigami.Page {
         }
     }
 
+    ListModel {
+        id: pluginsListModel
+    }
+
     MenuAddPlugins {
         id: menuAddPlugins
 
@@ -315,12 +319,10 @@ Kirigami.Page {
                             }
                         }
                     }
-
-                    model: ListModel {
-                        id: pluginsListModel
-                    }
+                    model: pluginsListModel
 
                     delegate: DelegatePluginsList {
+                        listModel: pluginsListModel
                     }
 
                     moveDisplaced: Transition {