Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing libpipewire in flatpak runtime #3673

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

violetmage
Copy link
Contributor

easyeffects bundles an older version of libpipewire to maintain compatability with hosts running pipewire < 0.3

Ubuntu 20.04 LTS is the last major distro with a pipewire < 0.3

Ubuntu 20.04 LTS ends general support at 2025-05-29

Since 20.04 is soon outdated, there is no longer a need to bundle an older libpipewire.

Copy link

github-actions bot commented Feb 16, 2025

Workflow failed, but the following artifacts are still available for this pull request:

@violetmage
Copy link
Contributor Author

Closes #3670

@wwmm wwmm merged commit 664e84d into wwmm:master Feb 16, 2025
5 of 10 checks passed
@wwmm
Copy link
Owner

wwmm commented Feb 16, 2025

Thanks! Let me ask you something unrelated to this PR. For some time our github action for the Flatpak package has been failing with the error

Build failed: Error: Create Artifact Container failed: The artifact name easyeffects-flatpak-merge-feac75d4b-into-284af7e59-x86_64 is not valid

Do you know what could be causing this? I did not have time to investigate what is going on.

@violetmage
Copy link
Contributor Author

violetmage commented Feb 16, 2025

Looks like this:
actions/upload-artifact#490

edit - fixes available, not merged:

flatpak/flatpak-github-actions#214

flatpak/flatpak-github-actions#215

edit 2 - resolved:
https://github.com/flatpak/flatpak-github-actions/releases/tag/v6.4

flatpak/flatpak-github-actions#217

@wwmm
Copy link
Owner

wwmm commented Feb 16, 2025

I see. So there is nothing we have to do on our side. Just waiting. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants