[Rgen] Move to use TypeInfo as the Type property in Parameters. #21998
Conversation
This will later be used to be ablet to correctly calculate the signature of the ObjCRuntime messaging method to perform a native call to a property or method.
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- src/rgen/Microsoft.Macios.Generator/DataModel/ParameterComparer.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/Formatters/ParameterFormatter.cs: Evaluated as low risk
- src/rgen/Microsoft.Macios.Generator/DataModel/Parameter.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ConstructorComparerTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/DelegateInfoTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ConstructorsEqualityComparerTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/MethodComparerTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/ConstructorTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/InterfaceCodeChangesTests.cs: Evaluated as low risk
- tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesComparerTests.cs: Evaluated as low risk
|
rolfbjarne
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 0 tests failed, 111 tests passed. Failures❌ dotnettests tests (MacCatalyst)🔥 Failed catastrophically on VSTS: test results - dotnettests_maccatalyst (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This will later be used to be able to correctly calculate the signature of the ObjCRuntime messaging method to perform a native call to a property or method.