E2123 Media Player Controller: toggle play/pause #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
====================================
Coverage 95% 95%
====================================
Files 65 65
Lines 2713 2720 +7
====================================
+ Hits 2582 2589 +7
Misses 131 131 ☔ View full report in Codecov by Sentry. |
The Ikea E2123 Medie Player controller has a toggle button to play/pause.
However, the mapping was set to "PLAY" instead of "PLAY_PAUSE", so it was not possible to pause the media player.
Pausing was only possible with a custom
merge_mapping:
toggle: play_pause
(Note: the same button is named "toggle" or "play_pause" depending on the firmware of the device)
|
Thank you @sevorl for the PR. I will release this fix on ControllerX v4.29.0. |
xaviml
added a commit
to harrismck/controllerx
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ikea E2123 Medie Player controller has a toggle button to play/pause. However, the mapping was set to "PLAY" instead of "PLAY_PAUSE", so it was not possible to pause the media player.
Pausing was only possible with a custom
merge_mapping:
toggle: play_pause
(Note: the same button is named "toggle" or "play_pause" depending on the firmware of the device)