Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include modified files in the generated matrix zip #20

Merged
merged 1 commit into from
Feb 28, 2021

Conversation

michaelarnauts
Copy link
Contributor

This modifies the create_zip method so it includes the changes made to the addon.xml.

By specifying HEAD, git will pick the latest committed changes. We can do a git stash create to create a git object that will contain all the modifications made and use that. Since this won't work when there are no actual changes done, we use variable substitution so we safely fallback to HEAD.

Fixes #19

@michaelarnauts
Copy link
Contributor Author

@enen92 I think you might be interested in this.

@enen92 enen92 requested a review from romanvm February 27, 2021 12:41
@romanvm
Copy link
Collaborator

romanvm commented Feb 28, 2021

Thank you for submitting this. Honestly, I could not find time to look into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated zips for matrix don't have a modified addon.xml
2 participants