Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlaybackState: Enable Actions #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fritsch
Copy link
Member

@fritsch fritsch commented Apr 13, 2024

We should properly identify the actions of the media session as well, cause SetActions needs them.

@joseluismarti
Copy link
Contributor

You also have to enable these constants in the header file

@a1rwulf
Copy link
Member

a1rwulf commented Apr 15, 2024

You also have to enable these constants in the header file

Oh indeed my bad, didn’t think about that. Thx for the catch!!
edit:
Do we really need to, though?
Seems they are just defined in the cpp file to avoid clashes with some core macros?
See:

/* Clash with internal macro

@joseluismarti
Copy link
Contributor

In order to be used from other classes they need to be in the header.
There should be no conflict if used in this way: CJNIPlaybackState::ACTION_PLAY

@fritsch
Copy link
Member Author

fritsch commented Apr 15, 2024

You also have to enable these constants in the header file

Thanks git add for the win ;-)

@fritsch
Copy link
Member Author

fritsch commented Apr 15, 2024

Let's keep it open for a bit - I want to fix the other bug for the MediaSession first and time is very limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants