[plugin.video.piped] 1.0.0

[syhlx]

Description

New addon which allows users to access any Piped instance, login and manage their playlists and watch history.

More information about Piped:
Piped GitHub Repository
Piped Official Instance

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practice but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.
• If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

[basrieter]

Please fix the issues pointed out by the add-on checker. Then I will have a further look.

[syhlx]

This should fix all the issues pointed out by the add-on checker

[basrieter]

Could you have a look at the code for the services? It does not seem to handle aborts correctly.

[basrieter]

Why this call? Makes no real sense if you don't use the output?

[basrieter]

If abortRequested() results in True, the httpservice and scheduler aren't stopped properly and could cause Kodi to wait for a long time.

[basrieter]

If scheduler.stop() does not finish, the script waits for 200ms and then stops it again? In the Scheduler.stop() you call self.join() which should actually block until the thread stopped.

[syhlx]

Before I commit anything, does this seem right to you?

class Service(xbmc.Monitor):
  def __init__(self):
    httpservice = Thread(target=HttpService)
    scheduler = Scheduler()
    httpservice.daemon = True
    scheduler.daemon = True
    player = Player()

    while not self.waitForAbort(5):
      try:
        if not httpservice.is_alive(): httpservice.start()
        if not scheduler.is_alive(): scheduler.start()
      except:
        pass

    scheduler.stop()

[basrieter]

Yes that makes more sense. Also make sure the httpservice is stopped in the line under the scheduler.stop()

[syhlx]

Done