Fix Dataset and Variable types
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-yogesh
approved these changes
Feb 6, 2025
| @@ -49,5 +49,5 @@ export interface Variable { | |||
| volumeRenderMode?: VolumeRenderMode; | |||
| volumeIsoThreshold?: number; | |||
| htmlRepr?: string; | |||
| attrs: Record<string, React.ReactNode>; | |||
| attrs: Record<string, JsonPrimitive | JsonPrimitive[]>; | |||
There was a problem hiding this comment.
So, here we expect the attrs to be either JsonPrimitive or JsonPrimitive[], and you have defined JsonObject below mainly for the wms file?
There was a problem hiding this comment.
Yes. There may be other possible applications in the code base still which are currently of type unknown.
However, I don't really understand the intent of your question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@b-yogesh in Oct 2024 you changed the
attrsproperty of theDatasetandVariableinterfaces to useReactNode. This is not acceptable for Redux-managed state types.In this PR I introduced
util/json.tsto fix this.