Set BPF Skeleton name to base name of ebpf file #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Erm, what bug are you fixing here? We don't actually pass any names with a directory prefix as skeleton names AFAIK? |
|
Not a bug but more of a feature. I use the xdp-tools build system as a scaffold for my libxdp-based programs. If I or someone else wants to have the eBPF programs in a special directory then he needs this. |
|
Hmm, okay, well I guess this doesn't hurt to include. Do note that using the repository like this is not something that's explicitly supported, so I won't promise not to make changes that you'll have to adapt to :) |
tohojo
requested changes
Sep 11, 2024
jalalmostafa
force-pushed
the
master
branch
from
52c1c42 to
311f214
Compare
|
I just fixed the commit message. I added removing *.ll files in nested directories in the |
jalalmostafa
force-pushed
the
master
branch
4 times, most recently
from
e0f44b0 to
cf5ceb1
Compare
tohojo
requested changes
Sep 19, 2024
jalalmostafa
force-pushed
the
master
branch
from
b39c004 to
6471272
Compare
|
Better, but now the commit message disappeared again :( |
The current build system sets the name of the generated skeleton directly to the file's name minus the .skel.h suffix. In case the eBPF program was in a nested directory, this leads to syntax errors in the skeleton file. This commit support ebpf programs in nested directory by poping out the directory part in the eBPF program name without breaking the build of currently available eBPF program. Signed-off-by: Jalal Mostafa <[email protected]>
jalalmostafa
force-pushed
the
master
branch
from
6471272 to
09d50a9
Compare
|
Oops. Sorry. |
tohojo
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build system sets the name of the generated skeleton directly to the file's name minus the
.skel.hsuffix.Passing names of eBPF targets that contain a directory will result in wrong names e.g.
bpf/xdp_program.bpf.owill have a skeleton file of the namebpf/xdp_program.skel.hand consequently the program name will bebpf/xdp_programinstead ofxdp_program. The commit pops out the directory part from the name.