Fix function return to be -errno not errno #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected behavior is that functions return -errno on error. Correct two locations where errno was returned directly as a positive integer. This affects xsk_umem__create_with_fd() and xsk_socket__create_shared(). Signed-off-by: Brian Poole <[email protected]>
brian90013
force-pushed
the
negative-errno
branch
from
73e7b72 to
4fcfbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the expected API behavior is functions return
-errnoon error. There are two locations,xsk_umem__create_with_fd()andxsk_socket__create_shared()wherereturn errnois used instead ofreturn -errno. This led libxdp library functions to return positive values. This problem was reported in issue #473.