[WIP]: Initialise arm_cf and begin beq implementation #3760
Conversation
|
I've been stuck on this error for a while now so just pushing this as WIP in case anyone could help speed things up: |
|
|
||
| // CHECK-NEXT: arm_cf.beq %x1, %x2, ^testlabel | ||
| // CHECK-ASM: arm_cf.beq x1, x2, ^testlabel | ||
| arm_cf.beq %x1, %x2, ^testlabel : (!arm.reg<x1>, !arm.reg<x2>) |
There was a problem hiding this comment.
I think the issue is you've that you've referred to a block that doesn't exist
There was a problem hiding this comment.
This is a good opportunity to fix the error message in a separate PR!
There was a problem hiding this comment.
PR for fixing error message: #3762
| def assembly_line_args(self): | ||
| then_label = self.then_block.first_op | ||
| assert isinstance(then_label, arm.ops.LabelOp) | ||
| return (self.s1, self.s2, then_label.label.data) |
There was a problem hiding this comment.
It would be good to allow both str and StringAttr here
| return (self.s1, self.s2, then_label.label.data) | |
| return (self.s1, self.s2, then_label.label) |
There was a problem hiding this comment.
It would be great to address this before merging, I'm actually leaning towards not allowing strings here at all, requiring the label attribute directly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3760 +/- ##
==========================================
- Coverage 91.30% 90.15% -1.16%
==========================================
Files 467 460 -7
Lines 58053 58322 +269
Branches 5575 5692 +117
==========================================
- Hits 53006 52580 -426
- Misses 3617 4350 +733
+ Partials 1430 1392 -38 ☔ View full report in Codecov by Sentry. |
Add arm_cf dialect and implement beq instruction