[WIP] tools: move verification and parsing command-line arguments from xDSLOptMain to CommandLineTool

[compor]

This PR:

• moves verification and parsing command-line arguments from xDSLOptMain to CommandLineTool

as also discussed in #3866

[alexarice]

I think my preference is still for these checks to happen once in xDSLOptMain.run, instead of being scattered

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (f0a3aac) to head (e28e098).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3915   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         466      466           
  Lines       57985    57985           
  Branches     5566     5566           
=======================================
  Hits        52929    52929           
  Misses       3629     3629           
  Partials     1427     1427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[compor]

I think my preference is still for these checks to happen once in xDSLOptMain.run, instead of being scattered

How do you do it downstream? Do you inherit xDSLOptMain then?
I know xdsl-smt does that, but not sure if that's the recommended practice or what the needs downstream might be.

[superlopuh]

Why this change? It doesn't make sense for xdsl-run to have parser diagnostics

[compor]

Why this change? It doesn't make sense for xdsl-run to have parser diagnostics

True, I'm going to move them back and deal with the parse_chunk diagnostics exception now that #3915 is in

[superlopuh]

Let's close this in the meantime?

[compor]

can't I reuse it to flip things around?

[superlopuh]

What's the benefit of having it open?

[compor]

I've moved it to WIP

[alexarice]

I think my preference is still for these checks to happen once in xDSLOptMain.run, instead of being scattered

How do you do it downstream? Do you inherit xDSLOptMain then?

Sorry, I missed this, I inherit from xDSLOptMain:

class QuoptMain(xDSLOptMain):
    def register_all_dialects(self):
        for name, dialect in get_all_dialects().items():
            self.ctx.register_dialect(name, dialect)

    def register_all_passes(self):
        for name, pass_ in get_all_passes().items():
            self.register_pass(name, pass_)

    def register_all_targets(self):
        super().register_all_targets()

[compor]

I think my preference is still for these checks to happen once in xDSLOptMain.run, instead of being scattered

How do you do it downstream? Do you inherit xDSLOptMain then?

Sorry, I missed this, I inherit from xDSLOptMain:

class QuoptMain(xDSLOptMain):
    def register_all_dialects(self):
        for name, dialect in get_all_dialects().items():
            self.ctx.register_dialect(name, dialect)

    def register_all_passes(self):
        for name, pass_ in get_all_passes().items():
            self.register_pass(name, pass_)

    def register_all_targets(self):
        super().register_all_targets()

thanks!