Steps can be increamented with - Semitone, Tone, Octave. According to choice of user #822
Conversation
sohamm20
commented
Nov 8, 2024
sohamm20
commented
|
Was there community demand for this? |
|
Can you give suggestions on how to add it as a preference? |
src/components/ScaleControls.vue
Outdated
| midiNoteNumberToName(scale.baseMidiNote, -1, scale.accidentalPreference) | ||
| }}</span> | ||
|
|
||
| <span> |
There was a problem hiding this comment.
It's been a while since I've programmed Vue, but it's something along the lines of adding the new preference, const state = useStateStore() and replacing this line with: <span v-if="state.showMidiStepVariants">.
|
@frostburn Added it as a preferance. Can you take a look? |
src/assets/main.css
Outdated
| @@ -126,7 +126,7 @@ ul.btn-group { | |||
| display: flex; | |||
| flex-flow: row wrap; | |||
| align-items: stretch; | |||
| gap: 0.15rem; | |||
| gap: 0.15rem 0.15rem; | |||
There was a problem hiding this comment.
Unnecessary change. If only one value is included, that value is used for both dimensions.
src/components/ScaleControls.vue
Outdated
| import { useStateStore } from '@/stores/state' | ||
| const state = useStateStore() | ||
|
|
||
| const stepx = ref("1") |
There was a problem hiding this comment.
Uninformative variable name. What is it associated with?
src/stores/state.ts
Outdated
| @@ -54,6 +54,8 @@ export const useStateStore = defineStore('state', () => { | |||
| // Debugging features. | |||
| const debug = ref(storage.getItem('debug') === 'true') | |||
|
|
|||
| const step = ref(storage.getItem('step') === 'true') | |||
There was a problem hiding this comment.
Uninformative storage key. Step of what?
src/views/PreferencesView.vue
Outdated
| @@ -54,6 +54,10 @@ const scale = useScaleStore() | |||
| <input id="debug" type="checkbox" v-model="state.debug" /> | |||
| <label for="debug" class="right-of-checkbox">Enable debugging features</label> | |||
| </div> | |||
| <div class="control checkbox-container"> | |||
| <input id="custom-step" type="checkbox" v-model="state.step" /> | |||
| <label for="custom-step" class="right-of-checkbox">Enable Custom Step Increment</label> | |||
There was a problem hiding this comment.
Not enough information for the user. Which step increment is this?
|
In addition to the step increment. Setting the property to anything other than 1 also fixes the "root" value. Is it intentional behavior that e.g. 61 is an invalid value when the Tone size is selected? Same goes for the Octave option: Are 0, 12, 24, etc. exactly the values you want? |
|
The motivation of this PR still escapes me. Can you elaborate on why you'd want this? |
|
If you wish to, remember to add your name to the Contributors list on the about page. |
|
I often need to switch between lower and higher octaves while staying on the same note. Normally, this would require pressing up or down 12 times, but this option makes the process much more convenient. |
Could we grey out the button if selecting it would result in an invalid root value? |
That's not what MIDI base note is for. It's more relevant for exporters. See keyboard shortcuts equave shift up/down for what you're doing. |
|
Can you try the equave shift keys to see if they already do what this PR is trying to achieve? If you're on mobile or otherwise do not have access to a numpad section on your keyboard I think you should replace this PR with a one that makes equave shift into an on-screen button. |
|
Sure, I will try |
