Set MenuEntry extra if it has valid value

MenuEntry has `extra` attr defined to `None` in its constructor, Thus always got `extra` attr, and default to `None`. Try to access `extra` attr would never got `AttributeError`, and thus got value default to `None`. However, the expected default value should be ` ` Set `extra` by checking whether MenuEntry `extra` got a valid value Signed-off-by: Lin Liu <[email protected]>
xenserver · Sep 22, 2023 · b323a17 · b323a17
1 parent f703ff7
commit b323a17
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/xcp/bootloader.py b/xcp/bootloader.py
@@ -586,11 +586,7 @@ def writeGrub2(self, dst_file = None):
                 if text:
                     print("\n".join(text), file=fh)
 
-            extra = ' '
-            try:
-                extra = m.extra
-            except AttributeError:
-                pass
+            extra = m.extra if m.extra else ' '
             print("menuentry '%s'%s{" % (m.title, extra), file=fh)
 
             try: