CA-371311: Handle network USB devices as PCI for interface rename #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 83.25% 83.26%
=======================================
Files 22 22
Lines 3363 3365 +2
=======================================
+ Hits 2800 2802 +2
Misses 563 563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andyhhp
reviewed
Feb 9, 2024
freddy77
force-pushed
the
support_usb_nics
branch
from
a768496 to
1cf61ea
Compare
andyhhp
reviewed
Feb 9, 2024
Currently the presence of any network USB device causes issues with the interface rename due to not being considered during the rename. For instance this causes collisions causing renames to fail due to destination name already used. Signed-off-by: Frediano Ziglio <[email protected]>
freddy77
force-pushed
the
support_usb_nics
branch
from
1cf61ea to
a48151a
Compare
andyhhp
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the presence of any network USB device causes issues with the interface rename due to not being considered during the rename.
For instance this causes collisions causing renames to fail due to destination name already used.