CA-389988: Do not consider USB network cards not named ethX #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USB network cards are assigned names using various rules. They can be usbX, ethX, wanX or wwanX based on different features. Our interface rename code bails out if the name is not in ethX format so ignore them. Signed-off-by: Frediano Ziglio <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 22 22
Lines 3355 3355
=======================================
Hits 2800 2800
Misses 555 555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GeraldEV
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USB network cards are assigned names using various rules. They can be usbX, ethX, wanX or wwanX based on different features. Our interface rename code bails out if the name is not in ethX format so ignore them.