Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows/main.yml: Fix coverage upload to Coveralls #137

Merged
merged 1 commit into from
May 13, 2024
Merged

.github/workflows/main.yml: Fix coverage upload to Coveralls #137

merged 1 commit into from
May 13, 2024

Conversation

bernhardkaindl
Copy link
Collaborator

Enhance the GitHub actions workflow to fix coverage upload to Coveralls:

  • Add a new common step to select the coverage file for upload
  • Fix a typo
  • Add an explanation that GitHub's API throttling is the cause for only uploading the coverage from py38-covcombine-check, and only on PRs and the master branch, not general pulls (It reduces the number of uploads and the chance of hitting the rate limit by a factor of 6)
  • State more clearly that the GitHub action using the Codecov CLI would be more reliable.
  • Fix uploading the coverage to Coveralls in parallel mode (merging coverage of 2.7, 3.8 and 3.11).

@bernhardkaindl bernhardkaindl force-pushed the gihub-ci-fix-coveralls-coverage-upload branch from 3897f9b to fcca026 Compare May 13, 2024 20:52
@bernhardkaindl bernhardkaindl merged commit 766dfa2 into xenserver:master May 13, 2024
4 checks passed
@bernhardkaindl bernhardkaindl removed the request for review from GeraldEV May 13, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bernhardkaindl