Don't use BIO for message transfer #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSL Buffered I/O doesn't preserver message boundaries when using the memory-based BIO. This means that multiple messages can be returned on a single call to BIO_read, which is incompatible with DTLS and usrsctp. This patch changes all cross-thread messaging to use GQueue-based message queues isntead of memory-backed BIO structures.
Removed some copy-pasta for flushing the DTLS outgoing memory bio. Now its a nice function in one place. Also removed some old use of the outgoing bio. Now, any time SSL_read or SSL_write is called, there should be a corresponding call to flush.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL Buffered I/O doesn't preserver message boundaries when using the
memory-based BIO. This means that multiple messages can be returned on a
single call to BIO_read, which is incompatible with DTLS and usrsctp.
This patch changes all cross-thread messaging to use GQueue-based
message queues isntead of memory-backed BIO structures.