Fix incorrect call to dist_psymbtonum when fact is SamePattern_SameRowPerm #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…risation This adds the same options that are available in pddrive, so they can be tested with the SamePattern and SamePattern_SameRowPerm options.
…Perm In cases where parallel symbolic factorisation with reusing the row and column permutations (i.e., Fact is SamePattern_SameRowPerm), the function ddist_psymbtonum() is incorrectly called and SuperLU_dist exits with the following error message: ERROR: call of dist_psymbtonum with fact equals SamePattern_SameRowPerm. This is already noted in the comments to ddist_psymbtonum(): "This routine should not be called for this case, an error is generated. Instead, pddistribute routine should be called." A valid fix seems to be to uncomment a line in the calling function, pdgssvx(), which handles the case when Fact is equal to SamePattern_SameRowPerm by instead calling pddistribute(), as suggested in the above-mentioned comment. The error can be easily reproduced with the following command: mpirun -np 2 pddrive3 -r 1 -c 2 -p 0 -q 5 -s 1 EXAMPLE/big.rua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sherry,
I found this issue while testing a combination of reusing the row and column permutations (SamePattern_SameRowPerm) and using parallel symbolic factorisation. This would fail with the assertion:
ERROR: call of dist_psymbtonum with fact equals SamePattern_SameRowPerm.I also found the following lines in
pdgssvx()near the call toddist_psymbtonum():Everything seems to work fine after I uncommented the top line and removed the bottom one.
It would be great if you could confirm if you think this is indeed a correct fix.
Thanks!