-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ipopt repo #5326
add Ipopt repo #5326
Conversation
@waruqi 这里好像没改 error: @programdir/modules/package/tools/autoconf.lua:184: attempt to concatenate a table value (local 'values')
stack traceback:
[@programdir/modules/package/tools/autoconf.lua:184]: in function '_get_cflags_from_packagedeps'
[@programdir/modules/package/tools/autoconf.lua:269]: in function 'buildenvs'
[@programdir/modules/package/tools/autoconf.lua:518]: in function 'configure'
[@programdir/modules/package/tools/autoconf.lua:564]: in function 'build'
[@programdir/modules/package/tools/autoconf.lua:593]: in function 'install'
[/__w/xmake-repo/xmake-repo/packages/i/ipopt/xmake.lua:53]: in function 'script'
[...dir/modules/private/action/require/impl/utils/filter.lua:114]: in function 'call'
[.../modules/private/action/require/impl/actions/install.lua:392]: |
应该是之前那个 host patch 的改动导致,需要花点时间调下。 |
It should be caused by changes in the previous host patch, and it will take some time to adjust. |
好的👌
…---Original---
From: ***@***.***>
Date: Thu, Sep 26, 2024 11:07 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [xmake-io/xmake-repo] add Ipopt repo (PR #5326)
应该是之前那个 host patch 的改动导致,需要花点时间调下。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
不是,还没改之前就是这样了,应该和 meson 之前的改法差不多。 |
No, it was like this before the change. It should be similar to the previous change of meson. |
这个是因为同时依赖了两个 gfortran 包,一个 library 一个 binary 。。 而传入 packagedeps 走 package:dep("gfortran") 只能随机取到一个,错误取到了 binary gfortran 包。。 而 binary gfortran 包的 on_fetch 返回的 信息,不属于库信息,所以 autoconf 里面追加时候,不兼容就报错了。。 |
This is because it depends on two gfortran packages at the same time, one library and one binary. . When passing in packagedeps and running package:dep("gfortran"), you can only get one randomly, and by mistake, you get the binary gfortran package. . The information returned by on_fetch of the binary gfortran package does not belong to the library information, so when appended to autoconf, an error will be reported if it is incompatible. . |
This reverts commit 3cf8a2e.
xmake-io/xmake#5666 等下这个 patch 另外,尽可能减少对 packagedeps 的设置,避免 flags 过长 |
好的,刚才提交包含了wxwidgets的修改,提交错了 |
可以先把 ipopt 单独先合进来, wxwidget 单独弄。。到时候审核也是挨个 pr 审核的,不要全混一起,也方便合并 |
好的,我刚才提交的时候把wxwidgets的包含进取了就导致后面的提交被污染了,我重新开一个pr吧 |
You can first combine ipopt separately and wxwidget separately. . When the time comes, the review will be done one by one, don’t mix them all together. |
Okay, when I submitted it just now, I expanded the inclusion of wxwidgets, which caused subsequent submissions to be contaminated. I'll open a new PR. |
可以把那几个 commit revert |
You can revert those commits |
revert + force push 下就行了 |
算了,我还是重新开一个pr吧 |
Forget it, I'd better open a PR again. |
添加ipopt包的linux支持