Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update llvm to 18.1.8 #6224

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

ArthurVasseur
Copy link
Contributor

No description provided.

packages/l/llvm/fetch.lua Outdated Show resolved Hide resolved
packages/l/llvm/xmake.lua Outdated Show resolved Hide resolved
packages/l/llvm/xmake.lua Outdated Show resolved Hide resolved
packages/l/llvm/xmake.lua Outdated Show resolved Hide resolved
@ArthurVasseur
Copy link
Contributor Author

ArthurVasseur commented Feb 3, 2025

@waruqi It looks like package:version() is only available after on_source is called, but not when the function itself is executed.

https://github.com/xmake-io/xmake/blob/fffc4190d7c706156e8421a7381c0bb62ae90cc8/xmake/modules/private/action/require/impl/package.lua#L1037-L1044

Maybe we can have package:requiredversion()?

@waruqi
Copy link
Member

waruqi commented Feb 3, 2025

@waruqi It looks like package:version() is only available after on_source is called, but not when the function itself is executed.

https://github.com/xmake-io/xmake/blob/fffc4190d7c706156e8421a7381c0bb62ae90cc8/xmake/modules/private/action/require/impl/package.lua#L1037-L1044

Maybe we can have package:requiredversion()?

we can not get version in on_source, because it has not been resolved yet.

packages/l/llvm/xmake.lua Outdated Show resolved Hide resolved
add_versions("16.0.6", "5e1f560f75e7a4c7a6509cf7d9a28b4543e7afcb4bcf4f747e9f208f0efa6818")
add_versions("17.0.6", "ce78b510603cb3b347788d2f52978e971cf5f55559151ca13a73fd400ad80c41")
add_versions("18.1.1", "9f59dd99d45f64a5c00b00d27da8fe8b5f162905026f5c9ef0ade6e73ae18df3")
if package:version():ge("18.1.8") then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot access package instance in description scope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I drop the version 18.1.8 if on_source is not available ?

@ArthurVasseur
Copy link
Contributor Author

@waruqi It looks like package:version() is only available after on_source is called, but not when the function itself is executed.
https://github.com/xmake-io/xmake/blob/fffc4190d7c706156e8421a7381c0bb62ae90cc8/xmake/modules/private/action/require/impl/package.lua#L1037-L1044
Maybe we can have package:requiredversion()?

we can not get version in on_source, because it has not been resolved yet.

I understand that, but you told me to use if package:version():ge("18.1.8") then

@waruqi
Copy link
Member

waruqi commented Feb 3, 2025

@waruqi It looks like package:version() is only available after on_source is called, but not when the function itself is executed.
https://github.com/xmake-io/xmake/blob/fffc4190d7c706156e8421a7381c0bb62ae90cc8/xmake/modules/private/action/require/impl/package.lua#L1037-L1044
Maybe we can have package:requiredversion()?

we can not get version in on_source, because it has not been resolved yet.

I understand that, but you told me to use if package:version():ge("18.1.8") then

I didn't notice it was called in on_source

local precompiled = false
local requiredversion = semver.new(package:requireinfo().version)
Copy link
Member

@waruqi waruqi Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package:requireinfo().version maybe nil, latest, version range, e.g. ">=18.1.8 <19.0", "18.x"

it has been not resolved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants