-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename libsdl packages to libsdl2 #6292
base: dev
Are you sure you want to change the base?
Conversation
there's a high chance at least one of the CI job will fail but this can be safely merged as it's just a package naming. |
All ci failed. It was very risky to merge so many changes at once. I think it should at least be split into several patches, tested and merged separately. patch 1: rename libsdl -> libsdl2, use set_base in libsdl |
3994562
to
62d9241
Compare
I split it into three commits:
CI will fail because it tries to compile every known version of libsdl2, some broke due to package updates, other were never tested on platforms that were enabled later, etc. So yeah I think this PR has to be manually reviewed, hopefully the commits diff are quite easy to read |
But all in one PR, it is too big, hard to review, and always causes CI to test all versions and packages. I want to split them into three PRs |
I don't see the point, it's easy to review each commit separately. Also if I split it, there will be a possibility for people to get xmake-repo with an incomplete migration (for example if we merge libsdl2 rename but not imgui dep update, people using imgui will get a warning because it will use libsdl) |
you can edit test.lua to only test latest version. if ci tests are passed, we can revert this patch, then merge this pr
pr 1: libsdl -> libsdl2, libsdl set_base + warnings. It will not break anything, only get one new warning. user still can use In addition, even if pr 1 is merged, it will not be synchronized to master immediately, so we still have time to submit pr 2 |
That's still quite a lot of work for something as simple as renaming a package, I don't have time right now to do it. |
pr1: #6307 |
pr2: #6316 |
pr3: #6317 |
this is the last pr now. and johnnyengine/box2d is broken, but I have no more time to fix it in these days. |
Now that #6225 is merged, the next step is to rename libsdl package to libsdl2