fix: syslink missing on linux in webui. #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
没通过的 Check 貌似与提交的修改没啥关系。 |
The failed Check seems to have nothing to do with the submitted modifications. |
waruqi
reviewed
Feb 10, 2025
packages/w/webui/xmake.lua
Outdated
|
|
||
| if on_check then | ||
| on_check("mingw", function (package) | ||
| assert(package:is_arch("x86_64"), "package(webui/mingw) only suport x86_64 arch") |
There was a problem hiding this comment.
就限制一个 arch ，直接 on_install 里面 mingw|x86_64 限制就行了，没必要加 on_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebUI 在 Linux 上需要链接 pthread 和 libdl，这些在高版本 gcc 上会自动链接，但在低版本 gcc(<=8) 上需要手动链接。