Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bascule helper package for scytale, talaria, and caduceus to use #188

Merged
merged 1 commit into from
May 10, 2023

Conversation

maurafortino
Copy link
Contributor

*Stop gap solution for scytale, talaria, and caduceus in order to remove the webpa-common logger with zap logger.

What's Included:

@maurafortino maurafortino added the webpa-common archival/deprecation work related to the archival & deprecation of webpa-common label May 9, 2023
@maurafortino maurafortino self-assigned this May 9, 2023
@guardrails
Copy link

guardrails bot commented May 9, 2023

⚠️ We detected 3 security issues in this pull request:

Vulnerable Libraries (3)
Severity Details
N/A pkg:golang/github.com/xmidt-org/webpa-common/[email protected]@v2.1.0 - no patch available
N/A pkg:golang/github.com/go-kit/[email protected]@v0.12.0 - no patch available
N/A pkg:golang/go.uber.org/[email protected]@v1.11.0 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #188 (dfe4645) into main (7ee0805) will decrease coverage by 3.47%.
The diff coverage is 69.54%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   88.97%   85.51%   -3.47%     
==========================================
  Files          35       36       +1     
  Lines        1225     1491     +266     
==========================================
+ Hits         1090     1275     +185     
- Misses        117      198      +81     
  Partials       18       18              
Flag Coverage Δ
unittests 85.51% <69.54%> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basculehelper/basculeHelper.go 69.54% <69.54%> (ø)

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, we're going to deprecate this relatively soon anyways. Cheers! 🍻

@maurafortino maurafortino merged commit efea101 into main May 10, 2023
@maurafortino maurafortino deleted the helper-package branch May 10, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants