Add hgw-mac key in metadata while preparing online and offline message #507
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
+ Coverage 58.60% 58.62% +0.02%
==========================================
Files 18 18
Lines 1872 1873 +1
==========================================
+ Hits 1097 1098 +1
Misses 733 733
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deviceStatus.go
Outdated
| @@ -36,6 +37,7 @@ func statusMetadata(d device.Interface) map[string]string { | |||
| metadata["/compliance"] = convey.MissingFields.String() | |||
| } | |||
|
|
|||
| metadata["hw-mac"] = strings.TrimPrefix(string(d.ID()), "mac:") | |||
There was a problem hiding this comment.
Device identifiers don't have to be a MAC address. Would it be ok to change this to:
metadata["/hw-deviceid"] = d.ID()This will result in the metadata looking like:
/hw-deviceid = mac:112233445566 or uuid:1edfb5ba-acb8-4e33-9793-a032d1e352ed depending on the way the CPE is named?
For users that assign a uuid for the combination of a CPE + account this will work as well.
There was a problem hiding this comment.
@schmidtw I have updated the code.
No description provided.