Error handling refactor #1280
Merged
Error handling refactor #1280
+215
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
force-pushed
the
11-17-error_handling_refactor
branch
5 times, most recently
from
cbce3c5
to
0cb760e
Compare
neekolas
force-pushed
the
11-17-error_handling_refactor
branch
from
0cb760e
to
b12ac5c
Compare
neekolas
force-pushed
the
11-17-error_handling_refactor
branch
from
b12ac5c
to
63e993b
Compare
mchenani
reviewed
Nov 18, 2024
| EncodeProto(#[from] prost::EncodeError), | ||
| #[error("proto decode error: {0}")] | ||
| DecodeProto(#[from] prost::DecodeError), | ||
| #[error(transparent)] |
There was a problem hiding this comment.
question: in the previous code we have this comment:
#[error("intent error: {0}")] Intent(#[from] IntentError),
is this change intentional?
There was a problem hiding this comment.
We should probably be doing more transparent error wrapping, since the additional comments usually add little incremental value. But this one was an accident, and that refactor could be handled separately.
mchenani
reviewed
Nov 18, 2024
neekolas
force-pushed
the
11-17-error_handling_refactor
branch
from
63e993b
to
3a3d31b
Compare
neekolas
force-pushed
the
11-17-error_handling_refactor
branch
from
3a3d31b
to
70cf5c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
MessageProcessingErrorintoGroupMessageProcessingErrorthat is more narrowly scopedGroupErrorto handle errors when processing Welcomesprocess_for_idtake a generic error type to support bothRetryableErrorexplicit and don't use_ => false