feat: use eslint-import-resolver-typescript instead #59
Conversation
|
|
||
| return firstResult.messages; | ||
| } | ||
|
|
||
| test.failing('main', async t => { |
There was a problem hiding this comment.
The previous test case is absolutely wrong.
| @@ -43,7 +43,11 @@ | |||
| "hint", | |||
| "simple" | |||
| ], | |||
| "dependencies": { | |||
| "eslint-import-resolver-typescript": "^2.7.1" | |||
There was a problem hiding this comment.
Shareable ESLint configs cannot have dependencies.
There was a problem hiding this comment.
Not sure to understand, or should I list it in peer?
There was a problem hiding this comment.
Interesting, but I'm also using this for a long time without any issue.
https://github.com/1stG/configs/blob/master/packages/eslint-config/package.json#L30
There was a problem hiding this comment.
FWIW I have a shared ESLint config with dependencies and it's only plugins that are a problem, everything else works as expected.
"@typescript-eslint/eslint-plugin": "^4.28.3",
"@typescript-eslint/parser": "^4.28.3",
"babel-eslint": "^10.1.0",
"eslint": "^7.18.0",
"eslint-config-airbnb": "^18.2.0",
"eslint-config-airbnb-typescript": "^12.3.1",
"eslint-config-prettier": "^6.12.0",
"eslint-import-resolver-alias": "^1.1.2",
"eslint-import-resolver-typescript": "^2.3.0",
"eslint-import-resolver-webpack": "^0.13.2",
"eslint-plugin-babel": "^5.3.0",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-jsx-a11y": "^6.3.1",
"eslint-plugin-react": "^7.20.3",
"eslint-plugin-react-hooks": "^4.0.8"There was a problem hiding this comment.
I would still prefer to wait until we move to flat ESLint config, which should have no problem with any kind of dependency.
close #58