-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force conversion unit in format_size #47
base: master
Are you sure you want to change the base?
Force conversion unit in format_size #47
Conversation
Hi @xolox All tests are passing except for Please have a look and let me know your thoughts. Many thanks, |
Hi again, Alright so adding tests for the new code solves the Please have a look and let me know your thoughts. Best regards, |
any news on this? |
Hi, Probably my changes are a bit too much for this package and that's why it hasn't been merge. I have just taken the relevant code out and copied it to my own script. @yodog I recommend you to do the same. If you think it is interesting, I might upload it to my own git repo and share it with you. Best regards, |
Hi,
We are interested in adding an optional flag to
format_size()
so you can force the conversion unit.Here is the desired behaviour:
Best regards,
Sebastian