Merge pull request #42 from xoofx/fix-vector-args

Fix argument passing for vector types
xoofx · Sep 11, 2023 · 22fb1f0 · 22fb1f0
2 parents 01995df + e8af27a
commit 22fb1f0
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Kalk.Core/Modules/HardwareIntrinsics/IntrinsicsModuleBase.cs b/src/Kalk.Core/Modules/HardwareIntrinsics/IntrinsicsModuleBase.cs
@@ -178,8 +178,10 @@ private T ToArg<TBase, T>(int argIndex, object value, int align = 0) where T : u
                 if (value is KalkVector vec)
                 {
                     var span = vec.AsSpan();
-                    var minSize = Math.Min(targetSize, span.Length);
-                    span = span.Slice(0, minSize);
+                    if (span.Length != targetSize)
+                    {
+                        throw new ScriptArgumentException(argIndex, $"Invalid size ({BytesToString(span.Length)}) for input vector `{vec.TypeName}`. Expecting {dimension} elements with {BytesToString(baseElementSize)} per element (with a total size of {BytesToString(targetSize)}).");
+                    }
                     span.CopyTo(MemoryMarshal.Cast<TBase, byte>(elements));
                 }
                 else
@@ -193,6 +195,8 @@ private T ToArg<TBase, T>(int argIndex, object value, int align = 0) where T : u
                 return Unsafe.As<TBase, T>(ref elements[0]);
             }
         }
+
+        private static string BytesToString(int size) => size == 1 ? $"{size} byte" : $"{size} bytes";
 
         private object ToResult<TBase, T>(T result) where T: unmanaged where TBase: unmanaged
         {