Add support for multiple teams #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just use something simple on the client side to filter out already-seen incidents in the report? |
xornivore
reviewed
Oct 31, 2023
Comment on lines
+71
to
+75
| teamIncidents, err := fetchIncidents(team, sinceAt, untilAt) | ||
| if err != nil { | ||
| exit("Failed to fetch incidents from Datadog: %v", err) | ||
| } | ||
| incidents = append(incidents, teamIncidents...) |
There was a problem hiding this comment.
Should we instead change the filter in fetchIncidents to grab multiple teams, I haven't touched this code in a while but should be possible? cc @badovm @robertjli
|
#11 was merged which resolves this issue, @just-chillin you can close this PR at your convenience 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for querying multiple teams, for example, foo and bar.
This is for the case where a single on call report may require joining incidents owned from multiple teams. For example a query like below is supported:
This will return all of the datadog incidents owned by foo and foo-bar.
Next Steps
At the moment, this PR simply concatenates the incidents owned by all of the teams. If
fooandfoo-barboth own incident-1234, it will show up twice in the incident report. To fix this, we need to do a query to the datadog-api liketeams:("foo" OR "foo-bar")instead of a single query per team. I didn't do this here because I didn't want to spend more than 30 minutes on this PR, and forming a query with raw strings didn't sound like much fun 🙃