Remove superfluous layer of output buffering in development webserver

xp-forge · Dec 2, 2023 · 2de5821 · 2de5821
1 parent 5fd004f
commit 2de5821
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -3,7 +3,8 @@ Web change log
 
 ## ?.?.? / ????-??-??
 
-
+* Removed superfluous layer of output buffering in development webserver
+  (@thekid)
 * Merged PR #105: Implement `WriteChunks::flush()` to use for explicitely
   flushing
   (@thekid)

diff --git a/src/main/php/xp/web/srv/Develop.class.php b/src/main/php/xp/web/srv/Develop.class.php
@@ -41,7 +41,12 @@ public function serve($source, $profile, $webroot, $docroot, $config, $args, $lo
     $arguments= ['-S', ('localhost' === $this->host ? '127.0.0.1' : $this->host).':'.$this->port, '-t', $docroot];
     $cmd= $os->compose($runtime->getExecutable()->getFileName(), array_merge(
       $arguments,
-      $runtime->startupOptions()->withSetting('user_dir', $docroot)->withSetting('include_path', $include)->asArguments(),
+      $runtime->startupOptions()
+        ->withSetting('user_dir', $docroot)
+        ->withSetting('include_path', $include)
+        ->withSetting('output_buffering', 0)
+        ->asArguments()
+      ,
       [$runtime->bootstrapScript('web')]
     ));