Prefer PHP 8 attributes over xp::$meta #28
+93
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR always uses the native syntax instead of using the information available in
xp::$meta
in PHP 8.Changes to the compiler
Here's what we could do in XP Compiler:
However, this would require changes to XP Core to parse annotations from the source code even if meta information is available - thus we'll have to wait for xp-framework/rfc#338