Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optimize for tracking when radiation (and delta_taper) is enabled #601

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix optimize for tracking when radiation (and delta_taper) is enabled #601

wants to merge 6 commits into from

Conversation

kparasch
Copy link
Contributor

@kparasch kparasch commented Feb 28, 2025 •
edited
Loading

Description

Thin slices were not passing radiation_flag and delta_taper with get_equivalent_element().
Added tests to catch the bug, and implemented the fix.

I found that if radiation_flag is not enabled, then delta_taper is silently ignored in many places, mainly in the tracking headers.

Closes xsuite/xsuite#610.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize_for_tracking breaks radiation
1 participant
@kparasch