handle insights when there are no events

xvvvyz · Jun 27, 2024 · 7d8d9bb · 7d8d9bb
1 parent cc8c0c6
commit 7d8d9bb
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 8 deletions.
diff --git a/app/_components/event-type-form.tsx b/app/_components/event-type-form.tsx
@@ -115,7 +115,7 @@ const EventTypeForm = ({
                 isMulti
                 label="Inputs"
                 name={field.name}
-                noOptionsMessage={() => 'Type to create a new input'}
+                noOptionsMessage={() => 'Type to create a new input.'}
                 onBlur={field.onBlur}
                 onChange={field.onChange}
                 onCreateOption={(value) =>

diff --git a/app/_components/form-banner.tsx b/app/_components/form-banner.tsx
@@ -90,7 +90,7 @@ const FormBanner = <T extends FieldValues>({
                 <Select
                   className="mt-16 text-left"
                   instanceId="template-select"
-                  noOptionsMessage={() => 'No templates'}
+                  noOptionsMessage={() => 'No templates.'}
                   onChange={(t) => {
                     const template = (
                       t as NonNullable<ListTemplatesWithDataData>[0]

diff --git a/app/_components/input-form.tsx b/app/_components/input-form.tsx
@@ -127,7 +127,7 @@ const InputForm = ({
               isMulti
               label="For"
               name={field.name}
-              noOptionsMessage={() => 'No subjects'}
+              noOptionsMessage={() => 'No subjects.'}
               onBlur={field.onBlur}
               onChange={(value) => field.onChange(value)}
               options={subjects as IOption[]}

diff --git a/app/_components/insight-form.tsx b/app/_components/insight-form.tsx
@@ -132,6 +132,7 @@ const InsightForm = ({ events, insight, subjectId }: InsightFormProps) => {
                 isClearable={false}
                 label="Input"
                 name={field.name}
+                noOptionsMessage={() => 'No inputs have been recorded.'}
                 onBlur={field.onBlur}
                 onChange={(value) => field.onChange((value as IOption).id)}
                 options={inputOptions}

diff --git a/app/_components/module-form-section.tsx b/app/_components/module-form-section.tsx
@@ -181,7 +181,7 @@ const ModuleFormSection = <T extends FieldValues, U extends ArrayPath<T>>({
             isCreatable
             isMulti
             name={field.name}
-            noOptionsMessage={() => 'Type to create a new input'}
+            noOptionsMessage={() => 'Type to create a new input.'}
             onBlur={field.onBlur}
             onChange={field.onChange}
             onCreateOption={(value) =>
@@ -208,7 +208,7 @@ const ModuleFormSection = <T extends FieldValues, U extends ArrayPath<T>>({
               <Select
                 className="mt-16 text-left"
                 instanceId="template-select"
-                noOptionsMessage={() => 'No templates'}
+                noOptionsMessage={() => 'No templates.'}
                 onChange={(t) => {
                   const template = (
                     t as NonNullable<ListTemplatesWithDataData>[0]

diff --git a/app/_components/subject-insights-page.tsx b/app/_components/subject-insights-page.tsx
@@ -39,7 +39,7 @@ const SubjectInsightsPage = async ({
       getCurrentUser(),
     ]);
 
-  if (!subject) return null;
+  if (!subject || !events) return null;
   const isTeamMember = !!user && subject.team_id === user.id;
   const shareOrSubjects = isPublic ? 'share' : 'subjects';
   const searchObject = new URLSearchParams(searchParams);
@@ -58,7 +58,7 @@ const SubjectInsightsPage = async ({
           Create insight
         </Button>
       )}
-      {!events?.length || !insights?.length ? (
+      {!insights?.length ? (
         <Empty className="mt-4">
           <InformationCircleIcon className="w-7" />
           No insights.

diff --git a/app/_components/template-form.tsx b/app/_components/template-form.tsx
@@ -123,7 +123,7 @@ const TemplateForm = ({
                 isMulti
                 label="Inputs"
                 name={field.name}
-                noOptionsMessage={() => 'Type to create a new input'}
+                noOptionsMessage={() => 'Type to create a new input.'}
                 onBlur={field.onBlur}
                 onChange={(value) => field.onChange(value)}
                 onCreateOption={(value) =>