CRISTAL-83: Basic Move/Rename is possible #610

pjeanjean · 2025-01-24T09:53:25Z

Jira URL

https://jira.xwiki.org/browse/CRISTAL-83

Changes

Description

Introduce PageRenameManager
Implement PageRenameManager for FileSystem
Add move() operation to storage
Add move and rename page actions
Small improvements to the navigation trees

Clarifications

This only supports FileSystem so far.
The PageRenameManager service currently does not do much, but will be improved later to support refactoring operations.
The Delete page action was slightly updated to add a "Cancel" button, to be more aligned with the new actions.

Screenshots & Video

Executed Tests

N/A

Expected merging strategy

Prefers squash: Yes
Backport on branches:
- N/A

* Introduce PageRenameManager * Implement PageRenameManager for FileSystem * Add move() operation to storage * Add move and rename page actions * Small improvements to the navigation trees

api/src/api/storage.ts

core/rename/rename-api/src/index.ts

ds/shoelace/src/vue/form/x-checkbox.vue

ds/shoelace/src/vue/x-dialog.vue

ds/shoelace/src/vue/x-navigation-tree.vue

ds/vuetify/src/vue/x-navigation-tree.vue

ds/vuetify/src/vue/form/x-checkbox.vue

* Improve documentation * Use classes instead of ids when possible * Remove !important * Handle move edge cases when preserving children

* Render shoelace dialogs over the sidebar

core/backends/backend-xwiki/src/xwikiStorage.ts

core/page-actions/page-actions-ui/langs/translation-en.json

core/page-actions/page-actions-ui/src/PageManagement.ts

core/rename/rename-api/src/index.ts

core/rename/rename-default/src/components/componentsInit.ts

ds/shoelace/src/vue/x-navigation-tree.vue

ds/vuetify/src/vue/form/x-checkbox.vue

electron/storage/src/electron/main/index.ts

manuelleduc

Thanks for working of this. I've made a few comments that we need to address before merging but looks good overall.

* Update core/page-actions/page-actions-ui/langs/translation-en.json Co-authored-by: Manuel Leduc <[email protected]>

* Small fixes

* Add missing comments

pjeanjean assigned manuelleduc Jan 24, 2025

CRISTAL-83: Basic Move/Rename is possible

f32dd1c

* Introduce PageRenameManager * Implement PageRenameManager for FileSystem * Add move() operation to storage * Add move and rename page actions * Small improvements to the navigation trees

pjeanjean force-pushed the CRISTAL-83 branch from cf6d376 to f32dd1c Compare January 24, 2025 10:05

manuelleduc reviewed Jan 24, 2025

View reviewed changes

api/src/api/storage.ts Outdated Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

core/rename/rename-api/src/index.ts Outdated Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/shoelace/src/vue/form/x-checkbox.vue Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/shoelace/src/vue/x-dialog.vue Outdated Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/shoelace/src/vue/x-navigation-tree.vue Outdated Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/shoelace/src/vue/x-navigation-tree.vue Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/vuetify/src/vue/x-navigation-tree.vue Show resolved Hide resolved

manuelleduc reviewed Jan 24, 2025

View reviewed changes

ds/vuetify/src/vue/form/x-checkbox.vue Outdated Show resolved Hide resolved

pjeanjean added 3 commits January 24, 2025 16:48

CRISTAL-83: Basic Move/Rename is possible

2f954e2

* Improve documentation * Use classes instead of ids when possible * Remove !important * Handle move edge cases when preserving children

CRISTAL-83: Basic Move/Rename is possible

a9ff36e

* Render shoelace dialogs over the sidebar

Merge branch 'main' into CRISTAL-83

1101b3e