Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up react and express #47

Merged
merged 5 commits into from
Jan 28, 2019
Merged

Set up react and express #47

merged 5 commits into from
Jan 28, 2019

Conversation

AsalaKM
Copy link
Contributor

@AsalaKM AsalaKM commented Jan 28, 2019

Relates #40 #46

initial server :

contain nodejs server (express) with react js server ( create-react-app server ) .

How To Use:
  • first install all dependencies by npm i && cd client && npm i
  • second run both servers ( reactjs server, express js server ) by npm run dev:both
  • check the browser on localhost:3000 the result should be initial react app page
  • check the test by npm test
  • check the client test by npm run test:client
Notes :
  • if you want to run express server js you can do it by npm run dev
  • if you want to run react server js you can do it by cd src/client && npm run start

@dupreesi
Copy link
Collaborator

looks good @AsalaKM is it ready to be merged in or do you want to setup Travis/ eslint in this PR?

@AsalaKM
Copy link
Contributor Author

AsalaKM commented Jan 28, 2019

Thanks @dupreesi
I think Its better to split the work in a different PRs

@dupreesi dupreesi merged commit 0c348db into master Jan 28, 2019
@dupreesi
Copy link
Collaborator

merged

@RamyAlshurafa RamyAlshurafa deleted the set-up-react-and-express branch January 28, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants