18 superuser manage data #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eruser-manage-data
relates #18
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 22.93% 22.93%
=======================================
Files 86 86
Lines 846 846
Branches 83 83
=======================================
Hits 194 194
Misses 574 574
Partials 78 78Continue to review full report at Codecov.
|
arrested-developer
suggested changes
Oct 24, 2019
arrested-developer
suggested changes
Oct 24, 2019
server/controllers/index.js
Outdated
| const router = express.Router(); | ||
|
|
||
| router.get("/locations", getLocations); | ||
| router.post("/locations", addLocation); | ||
|
|
||
| router.get("/reps/records", getSuperUserRecords); |
There was a problem hiding this comment.
Sorry, one last change - can you make this /reps/locations to match the other locations endpoint?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #18
Note: the rest of the issue is blocked until the other PR is merged