Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix publish secret and use correct runner os #231

Closed
wants to merge 1 commit into from
Closed

chore: fix publish secret and use correct runner os #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,34 @@ on:

jobs:
build:
name: Build binary for ${{ matrix.os }} and Node.js ${{ matrix.node-version }}
name: ${{ matrix.os }}/${{ matrix.arch }} Node ${{ matrix.node }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [16, 18, 20]
runs-on: ${{ matrix.os }}
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: [ 16, 18, 20 ]
arch: [ x64 ]

steps:
- name: Checkout
uses: actions/checkout@v3

# See https://github.com/nodejs/node-gyp/issues/2869
- name: Fix node-gyp and Python
run: python3 -m pip install packaging setuptools

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
run_install: |
args: [--ignore-scripts]

- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ matrix.node }}
architecture: ${{ matrix.arch }}
cache: "pnpm"

- name: Build binary
Expand All @@ -39,5 +45,5 @@ jobs:

- name: Release
env:
NODE_PRE_GYP_GITHUB_TOKEN: ${{ secrets.NODE_PRE_GYP_GITHUB_TOKEN }}
NODE_PRE_GYP_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: pnpm binary:release
18 changes: 12 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,34 @@ on:

jobs:
test:
name: Test on ${{ matrix.os }} and Node.js ${{ matrix.node-version }}
runs-on: ubuntu-latest
name: ${{ matrix.os }}/${{ matrix.arch }} Node ${{ matrix.node }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [16, 18, 20]
os: [ ubuntu-latest, macos-latest, windows-latest ]
node: [ 16, 18, 20 ]
arch: [ x64 ]

steps:
- name: Checkout
uses: actions/checkout@v3

# See https://github.com/nodejs/node-gyp/issues/2869
- name: Fix node-gyp and Python
run: python3 -m pip install packaging setuptools

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
run_install: |
args: [--ignore-scripts]

- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ matrix.node }}
architecture: ${{ matrix.arch }}
cache: "pnpm"

- name: Build binary
Expand Down