Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing read permission for app installation #190

Merged
merged 1 commit into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2022_11_28/models/group_0017.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class AppPermissions(GitHubModel):
default=UNSET,
description="The level of permission to grant the access token for custom property management.",
)
organization_copilot_seat_management: Missing[Literal["write"]] = Field(
organization_copilot_seat_management: Missing[Literal["write", "read"]] = Field(
default=UNSET,
description="The level of permission to grant the access token for managing access to GitHub Copilot for members of an organization with a Copilot Business subscription. This property is in public preview and is subject to change.",
)
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/ghec_v2022_11_28/types/group_0017.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class AppPermissionsType(TypedDict):
organization_custom_roles: NotRequired[Literal["read", "write"]]
organization_custom_org_roles: NotRequired[Literal["read", "write"]]
organization_custom_properties: NotRequired[Literal["read", "write", "admin"]]
organization_copilot_seat_management: NotRequired[Literal["write"]]
organization_copilot_seat_management: NotRequired[Literal["write", "read"]]
organization_announcement_banners: NotRequired[Literal["read", "write"]]
organization_events: NotRequired[Literal["read"]]
organization_hooks: NotRequired[Literal["read", "write"]]
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2022_11_28/models/group_0017.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class AppPermissions(GitHubModel):
default=UNSET,
description="The level of permission to grant the access token for custom property management.",
)
organization_copilot_seat_management: Missing[Literal["write"]] = Field(
organization_copilot_seat_management: Missing[Literal["write", "read"]] = Field(
default=UNSET,
description="The level of permission to grant the access token for managing access to GitHub Copilot for members of an organization with a Copilot Business subscription. This property is in public preview and is subject to change.",
)
Expand Down
2 changes: 1 addition & 1 deletion githubkit/versions/v2022_11_28/types/group_0017.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class AppPermissionsType(TypedDict):
organization_custom_roles: NotRequired[Literal["read", "write"]]
organization_custom_org_roles: NotRequired[Literal["read", "write"]]
organization_custom_properties: NotRequired[Literal["read", "write", "admin"]]
organization_copilot_seat_management: NotRequired[Literal["write"]]
organization_copilot_seat_management: NotRequired[Literal["write", "read"]]
organization_announcement_banners: NotRequired[Literal["read", "write"]]
organization_events: NotRequired[Literal["read"]]
organization_hooks: NotRequired[Literal["read", "write"]]
Expand Down
6 changes: 6 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,12 @@ source = "https://raw.githubusercontent.com/github/rest-api-description/main/des
# { "$ref" = "#/components/schemas/organization" },
# ] }

# https://github.com/yanyongyu/githubkit/issues/189
# app installation permissions missing "read"
"/components/schemas/app-permissions/properties/organization_copilot_seat_management/enum" = { "<add>" = [
"read",
] }

# date-time search syntax should be string
# https://docs.github.com/search-github/getting-started-with-searching-on-github/understanding-the-search-syntax#query-for-dates
"/components/parameters/created/schema" = { format = "<unset>" }
Expand Down
Loading