Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Emit metrics for new headers handling behaviour #2259

Closed
wants to merge 1 commit into from

Conversation

biosvs
Copy link
Collaborator

@biosvs biosvs commented Apr 16, 2024

Replaced with #2267

@biosvs biosvs force-pushed the emit-metrics-for-new-behavior-ver-2 branch 4 times, most recently from 9493593 to df2f2c8 Compare April 16, 2024 15:11
@biosvs biosvs changed the title Emit metrics for new headers handling behaviour [WIP] Emit metrics for new headers handling behaviour Apr 17, 2024
@biosvs biosvs force-pushed the emit-metrics-for-new-behavior-ver-2 branch from df2f2c8 to 349f7f7 Compare April 17, 2024 15:48
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 80.80000% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (407d76c) to head (ae5acc0).

Files Patch % Lines
transport/tchannel/response_writer.go 85.91% 5 Missing and 5 partials ⚠️
transport/http/outbound.go 42.85% 4 Missing and 4 partials ⚠️
transport/grpc/outbound.go 33.33% 3 Missing and 3 partials ⚠️
transport/http/handler.go 60.00% 3 Missing and 3 partials ⚠️
transport/tchannel/outbound.go 40.00% 4 Missing and 2 partials ⚠️
transport/grpc/handler.go 20.00% 2 Missing and 2 partials ⚠️
transport/grpc/headers.go 90.00% 2 Missing and 2 partials ⚠️
transport/tchannel/channel_outbound.go 0.00% 1 Missing and 1 partial ⚠️
transport/tchannel/handler.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2259      +/-   ##
==========================================
- Coverage   85.20%   85.16%   -0.04%     
==========================================
  Files         270      272       +2     
  Lines       15555    15687     +132     
==========================================
+ Hits        13253    13360     +107     
- Misses       1877     1890      +13     
- Partials      425      437      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biosvs biosvs force-pushed the emit-metrics-for-new-behavior-ver-2 branch 5 times, most recently from 9827946 to 0d10937 Compare April 19, 2024 12:49
@biosvs biosvs force-pushed the emit-metrics-for-new-behavior-ver-2 branch from 0d10937 to ae5acc0 Compare April 19, 2024 17:07
@biosvs biosvs closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant