Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yast-sap-ha does not support SAPHanaSR-angi #46

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

varkoly
Copy link
Collaborator

@varkoly varkoly commented Nov 5, 2024

yast-sap-ha does not support SAPHanaSR-angi

The yast2-sap-ha does not know the SAPHanSR-angi.

Solution

Remove package requirement for SAPHanaSR
Detect which SAPHanaSR is installed
Use the corresponding templates.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11683353929

Details

  • 11 of 56 (19.64%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 29.271%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/clients/sap_ha.rb 0 4 0.0%
src/lib/sap_ha/configuration/hana.rb 11 52 21.15%
Files with Coverage Reduction New Missed Lines %
src/lib/sap_ha/configuration/hana.rb 1 40.95%
Totals Coverage Status
Change from base Build 10734354155: -0.09%
Covered Lines: 1213
Relevant Lines: 4144

💛 - Coveralls

@varkoly varkoly merged commit 5fe67c9 into yast:master Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants