Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

個人ページのAPIの繋ぎ込み(icebox) #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mokroke
Copy link
Collaborator

@mokroke mokroke commented Sep 12, 2022

#85

@nyatinte nyatinte self-requested a review September 18, 2022 09:54
Comment on lines +75 to +113
{/* サイドバーの画面 */}

<Drawer isOpen={isOpen} onClose={onClose} placement="left">
<DrawerOverlay />

<DrawerContent>
{/* サイドバーの要素はここから変更してください */}

<Container>
<DrawerHeader borderBottomWidth="1px">
<Flex alignItems="center" justifyContent="space-between">
<Text>各種リンク</Text>

<IconButton
aria-label="close-drawer"
colorScheme="orange"
icon={<CloseIcon />}
onClick={onClose}
size="sm"
/>
</Flex>
</DrawerHeader>

<DrawerBody>
<VStack p={5} spacing={10}>
{/* ボタンをmapで追加 */}

{button_texts.map((button_text) => {
return (
<Button
_hover={{ bg: 'blackAlpha.600' }}
bg="black"
borderRadius="20"
color="white"
key={button_text}
w="40"
>
{button_text}
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ネストが深すぎるようです

前にサイドバーの部分はコンポーネント分割したので、ローカルでpullしてコンフリクト解消してから再度コミットしてみてください!

@nyatinte nyatinte changed the title 称号のデータ構造を追加しました 称号のデータ構造を追加 Sep 18, 2022
@nyatinte nyatinte changed the title 称号のデータ構造を追加 個人ページのAPIの繋ぎ込み Sep 18, 2022
@YutaUra YutaUra self-assigned this Oct 6, 2022
@nyatinte nyatinte assigned nyatinte and unassigned YutaUra Nov 10, 2022
@nyatinte
Copy link
Collaborator

#192
スキーマの変更や、フロントの方でもコンフリクトが予想されるので上記PRに移行します

@nyatinte nyatinte changed the title 個人ページのAPIの繋ぎ込み 個人ページのAPIの繋ぎ込み(icebox) Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants