Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for matplotlib 3.8.x #1506

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: for matplotlib 3.8.x #1506

merged 2 commits into from
Dec 5, 2023

Conversation

melanopsis
Copy link
Contributor

This PR is to address #1455

Copy link

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd ask that this gets merged quickly as this issue breaks any attempt to use this module in my environment.

Big +1 from me.

aquemy
aquemy previously approved these changes Dec 4, 2023
@fabclmnt
Copy link
Contributor

fabclmnt commented Dec 4, 2023

@melanopsis can you please fix our PR title to follow the expected format - Eg. feat: (description), fix: (description), etc.

Otherwise this will break our pipelines

@fabclmnt fabclmnt requested review from aquemy and fabclmnt December 4, 2023 19:01
@aquemy aquemy dismissed their stale review December 4, 2023 19:02

Need to check the compatibility with lower version

@cgivre
Copy link

cgivre commented Dec 4, 2023

I'd be happy to shepherd this if the original author doesn't want to.

@alexbarros alexbarros changed the title Fix for matplotlib 3.8.x fix: for matplotlib 3.8.x Dec 4, 2023
@aquemy aquemy merged commit f978af0 into ydataai:develop Dec 5, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants