[Disk Manager] Refactoring: use testing client for dm integration tests #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gy2411
changed the title
gy2411
commented
Jan 21, 2025
| "github.com/ydb-platform/nbs/cloud/disk_manager/internal/pkg/types" | ||
| "github.com/ydb-platform/nbs/cloud/tasks/logging" | ||
| "golang.org/x/sync/errgroup" | ||
| ) | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| func (c *client) FillDisk( | ||
| type testingClient struct { | ||
| client *client |
There was a problem hiding this comment.
Тут нужно использовать именно тип client, а не интерфейс Client, так как в методах нужно будет иметь доступ к полю nbs структуры client.
Чтобы иметь возможность положить сюда client, пришлось чуть подрефакторить код фабрики. А именно, рядом с методом factory.GetClient добавил неэкспортированный метод factory.getClient, который возвращает client вместо Client.
gy2411
commented
Jan 21, 2025
| type partitionInfo struct { | ||
| Checkpoints []checkpoint `json:"Checkpoints"` | ||
| // We don't need other partitionInfo fields. | ||
| } |
There was a problem hiding this comment.
Эти две структуры нигде не использовались. Не знаю, для чего они тут были)
gy2411
commented
Jan 21, 2025
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| func (c *testingClient) Ping(ctx context.Context) (err error) { |
There was a problem hiding this comment.
Все методы, которые есть в интерфейсе Client, полностью делегируются.
Реализации остальных методов в точности перенесены из client, за тем исключением, что где-то вметсо c.nbs стало c.client.nbs.
gy2411
force-pushed
the
users/gayurgin/use_testing_client_for_dm_integration_tests
branch
from
0cf268a to
b1db1fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#892
Added TestingClient interface and used it in tests where needed.