Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing filesystem id on profile log write #2953

Merged
merged 15 commits into from
Feb 6, 2025
Merged

Fix missing filesystem id on profile log write #2953

Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
df9867d
Debug missing filesystem id on write profile log
proller Jan 30, 2025
eb5fa1d
Use STORAGE_VERIFY_DEBUG_C
proller Jan 30, 2025
b342754
Simpler
proller Jan 30, 2025
650fcb4
Fix
proller Jan 30, 2025
a8964b3
Fix
proller Jan 30, 2025
f486c5f
Merge remote-tracking branch 'upstream/main' into profile-log-debug
proller Jan 30, 2025
f6818bc
Merge remote-tracking branch 'upstream/main' into profile-log-debug
proller Jan 31, 2025
d0dfc4b
testme other log place
proller Feb 4, 2025
a5049e9
fix
proller Feb 4, 2025
eb91c6c
more fs id in TCallContext
proller Feb 4, 2025
ef3456d
clean
proller Feb 4, 2025
b5fc5ff
Merge remote-tracking branch 'upstream/main' into profile-log-debug
proller Feb 4, 2025
f2476ca
clean
proller Feb 4, 2025
6997858
Fix CreateSession response
proller Feb 5, 2025
0295b3b
Clean
proller Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cloud/filestore/libs/diagnostics/profile_log.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <cloud/storage/core/libs/common/scheduler.h>
#include <cloud/storage/core/libs/common/timer.h>
#include <cloud/storage/core/libs/common/verify.h>

#include <library/cpp/eventlog/eventlog.h>

Expand Down Expand Up @@ -71,6 +72,9 @@ void TProfileLog::Stop()

void TProfileLog::Write(TRecord record)
{
// TODO(proller): Remove debug after bug fix
STORAGE_VERIFY_DEBUG_C(record.FileSystemId.empty(), "", "", "Missing filesystem id in profile log");

Records.Enqueue(std::move(record));
}

Expand Down
Loading