Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SaveQueryDialog): should not duplicate component in DOM #1649

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Nov 18, 2024

This pull request introduces significant refactoring to the QueryEditor and SaveQuery components, focusing on integrating the NiceModal library for improved modal handling. The changes also include updates to the SaveQueryDialog and related components to enhance their functionality and usability.

Key changes include:

Integration of NiceModal:

Refactoring of SaveQueryDialog:

Removal of Unused Query Actions:

Hook Updates:

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
154 153 0 1 0

Bundle Size: ✅

Current: 66.11 MB | Main: 66.11 MB
Diff: 0.00 MB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug requested a review from astandrik November 18, 2024 14:26
@Raubzeug Raubzeug added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 3b37565 Nov 18, 2024
8 checks passed
@Raubzeug Raubzeug deleted the save-query-dialog branch November 18, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants